Skip to content

Bug 1756421: bring back explain tests #24058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Nov 1, 2019
Merged

Bug 1756421: bring back explain tests #24058

openshift-merge-robot merged 2 commits into from
Nov 1, 2019

Conversation

@soltysh
Copy link
Contributor

@soltysh soltysh commented Oct 30, 2019

Supersedes #23935
/assign @mfojtik

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 30, 2019

@soltysh: This pull request references Bugzilla bug 1756421, which is invalid:

  • expected dependent Bugzilla bug 1754640 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1756421: bring back explain tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 30, 2019
@soltysh soltysh mentioned this pull request Oct 30, 2019
Closed
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
@sttts
Copy link
Contributor

sttts commented Nov 1, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts
Copy link
Contributor

sttts commented Nov 1, 2019

/retest

@sttts
Copy link
Contributor

sttts commented Nov 1, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 1, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 1, 2019

@sttts: This pull request references Bugzilla bug 1756421, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 20b453b into openshift:master Nov 1, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 1, 2019

@soltysh: All pull requests linked via external trackers have merged. Bugzilla bug 1756421 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1756421: bring back explain tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh soltysh deleted the bug1756421 branch November 4, 2019 09:15
sttts
sttts reviewed Nov 11, 2019
View reviewed changes
test/extended/cli/explain.go
{Group: "operator.openshift.io", Version: "v1", Resource: "servicecatalogcontrollermanagers"},

// FIXME
// {Group: "operator.openshift.io", Version: "v1", Resource: "authentications"},
Copy link
Contributor

@sttts sttts Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

@stlaz stlaz Nov 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in #24165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knobunc knobunc Awaiting requested review from knobunc

@mfojtik mfojtik Awaiting requested review from mfojtik

2 more reviewers

@stlaz stlaz stlaz left review comments

@sttts sttts sttts left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mfojtik mfojtik

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@soltysh @openshift-ci-robot @sttts @stlaz @mfojtik @openshift-merge-robot